solve ratio problem

[bktech2021]

solves the ratio problem for laptops and fanless cards.

[alphastrata]

It is implemented https://docs.rs/nvml-wrapper/latest/nvml_wrapper/struct.Nvml.html#method.discover_gpus, it's probably not available on the platform (laptop gpus).

We need a better way to conditionally show/not-show this for sure.

You can actually see it working on a multi-gpu system here #6 (comment)

[bktech2021]

i was not able to compile, i will look again

[bktech2021]

/* snip

# Platform Support

    Only supports Linux.
    */
    // TODO: constructor for default pci_infos ^
    // Checked against local
    // Tested
    #[cfg(target_os = "linux")]
    #[doc(alias = "nvmlDeviceDiscoverGpus")]
    pub fn discover_gpus(&self, pci_info: PciInfo) -> Result<(), NvmlError> {
        let sym = nvml_sym(self.lib.nvmlDeviceDiscoverGpus.as_ref())?;

        unsafe { nvml_try(sym(&mut pci_info.try_into()?)) }
    }

/* snip */

as it writes, this function is only for linux, im testing it on windows. so i will try to not show "p to rescan" on windows

[alphastrata]

Good call, I too should've gone deeper in the docs before snarking, soz.

[alphastrata]

There is defnitely no issue with the code -- I'm thinking that maybe we should just not run the call to draw_fan-speed at all if we're on a fan-less system, because we're checking this every time the loop runs.

Wanna hoist something out side the loop to where we can check if we get values then just never run this code if we don't have to?

[bktech2021]

i will convert it to something like Result<Gauge, Error>, if error is no fans, it will get there is no fans. and, you can implement other errors in future.

[alphastrata]

Hey bktexh -- thanks for your contribution:

After thinking more about it I think we'll do something like this:

pub fn run(
    nvml: nvml_wrapper::Nvml,

   /* Snip */

    let mut gpu_list = crate::gpu::try_init_gpus(&nvml, lh)?; //Line 32, in `src/app.rs

    // Let's work out if there's any GPUs we can get a fan off.
    let has_fans = gpu_list
        .iter()
        .any(|gpu| gpu.inner.num_fans().map_or(0, |fc| fc) != 0);
   /* Snip */

    // Then later (in the endless loop:
    // Fanspeed:
    if has_fans {
        let fan_gauge = draw_fan_speed(gpu);
        f.render_widget(fan_gauge, chunks[2]);
    }

(apologies for not writing more code to exemplify what I'm after here, on mobile & on the move atm.

[alphastrata]

Thank you :)

[bktech2021]

i forgot something, we are only checking at program start, not when rescanning

[alphastrata]

I'll fix it in an hour or so -- don't think it'll tick anyone off too badly till then 😉