Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an option to not format headings as links #348

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added an option to not format headings as links #348

wants to merge 4 commits into from

Conversation

OZoneGuy
Copy link

@OZoneGuy OZoneGuy commented Apr 19, 2023 •
edited
Loading

Added :not-links to the dynamic block options to allow creating the table without having the headings as links.

Example:

#+BEGIN: org-ql :query (todo \"UNDERWAY\")
:columns (priority todo heading) :sort (priority date)
:ts-format \"%Y-%m-%d %H:%M\" :not-links t

Related to #330

This was referenced Apr 19, 2023
Open
Closed
@alphapapa alphapapa force-pushed the master branch 2 times, most recently from 059b10c to 77b4c2b Compare December 16, 2023 13:55
@TomoeMami
Copy link

Is this PR rejected？

@alphapapa
Copy link
Owner

Is this PR rejected？

If it were rejected, it would be rejected. This is the first time I've seen it.

@OZoneGuy Feel free to ping me on PRs that go unnoticed for a while. I have a lot of projects on here and it's easy to miss notifications.

I'll submit some feedback as a review.

alphapapa
alphapapa requested changes Jan 5, 2024
View reviewed changes
Copy link
Owner

@alphapapa alphapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

org-ql-search.el Outdated Show resolved Hide resolved
org-ql-search.el Outdated Show resolved Hide resolved
org-ql-search.el Outdated Show resolved Hide resolved
@alphapapa alphapapa added this to the 0.9 milestone Jan 5, 2024
@alphapapa alphapapa linked an issue Jan 5, 2024 that may be closed by this pull request
Don't use links in dynamic block #330
Open
@OZoneGuy OZoneGuy requested a review from alphapapa January 7, 2024 23:22
@alphapapa
Copy link
Owner

Sorry, but I will have to ask you to disentangle this and #349, as they both contain some of the same changes. Magit should make it easy enough; I'd suggest making a new branch and cherry-picking the changes, then pushing the new branch to this PR's reference.

@OZoneGuy
Copy link
Author

OZoneGuy commented Jan 8, 2024

@alphapapa, both PRs are untangled now. I will rebase the one that gets merged in last if there are any merge conflicts. PTAL

@OZoneGuy
Copy link
Author

OZoneGuy commented Feb 4, 2024

CC @alphapapa

nickanderson
nickanderson reviewed Feb 9, 2024
View reviewed changes
org-ql-search.el
@@ -296,16 +296,17 @@ Valid parameters include:
:ts-format Optional format string used to format
timestamp-based columns.

:not-links Optional boolean. If non-nil, don't make headings
into links.
:link Optional flag. Defaults to `t`. When non-nil, links
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I was going to suggest this but see you already made that change.

@nickanderson
Copy link

@alphapapa pinging since you said to if it's been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickanderson nickanderson nickanderson left review comments

@alphapapa alphapapa Awaiting requested review from alphapapa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

Don't use links in dynamic block
4 participants
@OZoneGuy @TomoeMami @alphapapa @nickanderson