Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocked predicate #190

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

akirak
Copy link
Contributor

@akirak akirak commented Feb 11, 2021

I have been using this predicate in my config to filter out blocked tasks. I think this can be useful to others, so I am sending a PR.

In most cases, I combine this predicate with negation as follows:

(and (todo)
  (not (blocked))
  ...)

@akirak
Copy link
Contributor Author

akirak commented Feb 11, 2021

This can be an alternative to sibling predicates (#105).

@alphapapa alphapapa self-assigned this Jul 27, 2021
@alphapapa alphapapa added this to the 0.7 milestone Jul 27, 2021
@alphapapa
Copy link
Owner

Thanks, this looks like an obviously good idea. :) Sorry for overlooking the PR; feel free to tag me or bump things if I forget.

@akirak akirak force-pushed the feature/blocked-pred branch from 59beb87 to 55c83a1 Compare July 28, 2021 08:33
@akirak
Copy link
Contributor Author

akirak commented Jul 28, 2021

Resolved the conflict.

@telenieko
Copy link

Is there any particular reason this never got merged? Just found this PR looking precisely for a blocked predicate!

@alphapapa
Copy link
Owner

alphapapa commented May 18, 2022 via email

@telenieko
Copy link

I work on these projects in my spare time.

I understand. I was mostly asking about feedback on the last comment in this PR to see if I could take the mantle from @akirak and finish the work.

Though my Elisp may not yet be good enough!

@akirak
Copy link
Contributor Author

akirak commented May 18, 2022

I am fine without this feature getting merged. Anyone can define blocked locally.

@alphapapa alphapapa force-pushed the feature/blocked-pred branch from 55c83a1 to 6afe3be Compare March 10, 2023 09:33
@alphapapa alphapapa merged commit 7f68db9 into alphapapa:master Mar 10, 2023
@alphapapa
Copy link
Owner

@akirak Thanks for your patience. This will be in v0.7. :)

@akirak akirak deleted the feature/blocked-pred branch March 10, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants