Skip to content

Commit

Permalink
Comment: Add/remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
alphapapa committed Jan 3, 2020
1 parent e9d5bca commit d28d54c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
12 changes: 0 additions & 12 deletions helm-org-ql.el
Original file line number Diff line number Diff line change
Expand Up @@ -195,18 +195,6 @@ Is transformed into this query:
(setq helm-org-ql-buffers-files buffers-files))
(ignore-errors
;; Ignore errors that might be caused by partially typed queries.

;; FIXME: This doesn't prevent warnings that are errors occurring during
;; byte-compilation due to partially typed values which can't be correctly
;; pre-processed, e.g. "ts:to=2019-01-0", which can't be parsed into a
;; timestamp. A "*Compile-Log*" buffer is displayed with "Error: Wrong type
;; argument: integerp, nil". With my Helm settings, it's hidden as soon as
;; the query is typed correctly, so it's tolerable, but I'd prefer to fix it.
;; I haven't found a way to ignore the error/warning; `with-no-warnings' has
;; no effect, and we're already using `ignore-errors'. The only solution I
;; can think of would be to ignore the errors/warnings higher up the chain
;; where byte-compilation is actually done, but it might not be a good idea
;; to always ignore such errors/warnings.
(org-ql-select buffers-files query
:action `(helm-org-ql--heading ,window-width))))))
:match #'identity
Expand Down
1 change: 1 addition & 0 deletions org-ql.el
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ Returns cons (INHERITED-TAGS . LOCAL-TAGS)."
;; TODO: Use --value-at for tags cache.

(defun org-ql--value-at (position fn)
;; TODO: Either rename to `value-at-point' and remove `position' arg, or move point.
"Return FN's value at POSITION in current buffer.
Values compared with `equal'."
;; I'd like to use `-if-let*', but it doesn't leave non-nil variables
Expand Down

0 comments on commit d28d54c

Please sign in to comment.