Merge pull request #1592 from alphagov/update-slack-team

Allow alerts to be posted to a different Slack channel
alphagov · Oct 22, 2024 · e056a93 · e056a93
2 parents 07aa93c + a444760
commit e056a93
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/app/models/application.rb b/app/models/application.rb
@@ -143,6 +143,6 @@ def live_environment
   end
 
   def team_name
-    Repo.find_by(app_name: name)&.dig("team") || "#govuk-developers"
+    Repo.find_by(app_name: name)&.dig("alerts_team") || "#govuk-developers"
   end
 end
diff --git a/test/unit/application_test.rb b/test/unit/application_test.rb
@@ -275,7 +275,7 @@ class ApplicationTest < ActiveSupport::TestCase
     should "return the name of the team that owns the app" do
       response_body = [{
         "app_name" => "account-api",
-        "team" => "#tech-content-interactions-on-platform-govuk",
+        "alerts_team" => "#tech-content-interactions-on-platform-govuk",
       }].to_json
       stub_request(:get, Repo::REPO_JSON_URL).to_return(status: 200, body: response_body)
 
@@ -287,7 +287,7 @@ class ApplicationTest < ActiveSupport::TestCase
     should "return general dev slack channel when it can't find team (because app names don't match)" do
       response_body = [{
         "app_name" => "content-data-admin",
-        "team" => "#govuk-platform-security-reliability-team",
+        "alerts_team" => "#govuk-platform-security-reliability-team",
       }].to_json
       stub_request(:get, Repo::REPO_JSON_URL).to_return(status: 200, body: response_body)
 

diff --git a/test/unit/jobs/post_out_of_sync_deploys_job_test.rb b/test/unit/jobs/post_out_of_sync_deploys_job_test.rb
@@ -8,8 +8,8 @@ class PostOutOfSyncDeploysJobTest < ActiveJob::TestCase
 
   should "enqueue a SlackPosterJob for each team with out-of-sync apps" do
     response_body = [
-      { "app_name" => "account-api", "team" => "#tech-content-interactions-on-platform-govuk" },
-      { "app_name" => "asset-manager", "team" => "#govuk-publishing-platform" },
+      { "app_name" => "account-api", "alerts_team" => "#tech-content-interactions-on-platform-govuk" },
+      { "app_name" => "asset-manager", "alerts_team" => "#govuk-publishing-platform" },
     ].to_json
 
     stub_request(:get, Repo::REPO_JSON_URL).to_return(status: 200, body: response_body)
@@ -48,7 +48,7 @@ class PostOutOfSyncDeploysJobTest < ActiveJob::TestCase
   should "not enqueue a SlackPosterJob if no teams have out-of-sync apps" do
     response_body = [{
       "app_name" => "account-api",
-      "team" => "#tech-content-interactions-on-platform-govuk",
+      "alerts_team" => "#tech-content-interactions-on-platform-govuk",
     }].to_json
     stub_request(:get, Repo::REPO_JSON_URL).to_return(status: 200, body: response_body)