Check for duplicate id attributes in HTML
#5326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quis
changed the title
id attributes in HTML
quis
force-pushed
the
check-for-duplicate-ids
branch
3 times, most recently
from
1d71e7b to
a67425b
Compare
quis
force-pushed
the
check-for-duplicate-ids
branch
2 times, most recently
from
0fe71e5 to
4fa35a9
Compare
It’s invalid HTML to have multiple elements with the same `id` attribute. Plus it can cause trouble for Javascripts, and make anchor linking unpredictable.
This wasn’t doing anything styling-wise or functionality-wise, and it had the same ID as its parent element
I think we used to have this as a target for some ARIA attributes, but since moved way from using those here.
Because we are rendering the same form multiple times on one page we need to make sure each time the hidden field is rendered it gets a different ID.
Where the table rows don’t need IDs, let’s not show them
We’re not relying on these IDs being fixed elsewhere in the tests, so let’s make them random.
Functional tests still need these on the page: https://github.com/alphagov/notifications-functional-tests/blob/c9549ded6ab64ea61ba812a41cd7153541ceb784/tests/pages/pages.py#L917 This gives us a way of having the IDs in test fixtures still be deterministic (up to single digits in base 16), but also unique
quis
force-pushed
the
check-for-duplicate-ids
branch
from
4fa35a9 to
125ed67
Compare
rparke
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s invalid HTML to have multiple elements with the same
idattribute. Plus it can cause trouble for Javascripts, and make anchor linking unpredictable.