Add csp_nonce for inline script and gov_template #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spatel033
force-pushed
the
update-ithc-script-src-headers
branch
from
674ec4d to
3b22955
Compare
tombye
requested changes
Dec 13, 2024
There was a problem hiding this comment.
I left a comment but also wanted to suggest this adds a test to this section of tests/conftest.py for script tags that either contain inline code or reference a file not hosted on our domain. That would both identify any current scripts without the nonce attribute and protect us from adding any in future.
Also to say this is great work and much needed. Thanks for doing it!
spatel033
force-pushed
the
update-ithc-script-src-headers
branch
6 times, most recently
from
1480ec3 to
bbeb4fb
Compare
tombye
requested changes
Dec 13, 2024
spatel033
force-pushed
the
update-ithc-script-src-headers
branch
2 times, most recently
from
62596af to
21d13d0
Compare
kr8n3r
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
based on #5325 (comment) I'm happy with this but it should wait for Tom as he requested changes
Previously we added `unsafe-inline` and `unsafe-eval` directives for `script-src` header. We can remove these directives as part of ITHC after removing `Hogan`. Additionally to fix CSP errors added `csp_nonce` for request to allow `govuk_frontend_jinja/template.html` and inline `script`.
spatel033
force-pushed
the
update-ithc-script-src-headers
branch
from
21d13d0 to
0bf7ea6
Compare
tombye
approved these changes
Dec 17, 2024
kr8n3r
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we added
unsafe-inlineandunsafe-evaldirectives forscript-srcheader. We can remove these directives as part of ITHC after removingHogan. Additionally to fix CSP errors addedcsp_noncefor request to allowgovuk_frontend_jinja/template.htmland inlinescript. More details on this card.