Extensions for text and color styles template

[bimawa]

Extended templates:

• ColorStyles added UIColor return type. Now we can use style directly in colors

let color: UIColor = .primaryWhite40

• TextStyles added default system font, if font not found.
• TextStyles added String extension for make NSAttributesString directly:

let attributedText = "titleName".style(as: TextStyle.iosBodySmall.withColor(.primaryWhite))

@almazrafi please check before merge. I make changes in blind mode. No time for check in on my side. #74

[bimawa]

Better, if I update demo prj? Пт, 13 нояб. 2020 г. в 20:00, Almaz Ibragimov <[email protected]>:

***@***.**** commented on this pull request. ------------------------------ In Templates/ColorStyles.stencil <#75 (comment)>: > @@ -35,7 +35,7 @@ import AppKit green: {{ style.color.green }}, blue: {{ style.color.blue }}, alpha: {{ style.color.alpha }} - ) + ).color This change seems to break the demo project: https://github.com/almazrafi/Fugen/pull/75/checks?check_run_id=1237672063 Can we merge PR without this change? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKUJEOWJEPIFTCQA5CKBHTSPVCZLANCNFSM4SLTU3UQ> .

-- С уважением, Максим.

[almazrafi]

Better, if I update demo prj?

This will still break backward compatibility. It looks like we need to add a separate Colors type with static UIColor properties.

[bimawa]

@almazrafi ok I did work by remarks, check it pls.

[bimawa]

backward compatibility

Isn't Apple Way ^_^
I recommend prepare BRAKING CHANGES version for it.

[timbaev]

I think, we should not use default system font, if font not found. You should validate all text styles on application start, for example:

do {
    try TextStyle.validate()
} catch {
    assertionFailure("\(error)")
}

Also, you can generate TextStyles using system font by specifying in templateOptions (will be available in next release):

textStyles:
  file:
    key: ...
    includedNodes:
      - ...
  destination: ...
  templateOptions:
    usingSystemFonts: true

[timbaev]

Could we write another extension instead of this to the bottom of file?

{{ accessModifier }} extension {{ colorTypeName }} {

    // MARK: - Type Methods

    static func style(_ colorStyle: {{ styleTypeName }}) -> {{ colorTypeName }} {
        colorStyle.color
    }
}

Usage example:

view.backgroundColor = .style(.uiBackground)

[timbaev]

Need to align template code:

{{ accessModifier }} extension String {
    func styled(as style: {{ styleTypeName }}) -> NSAttributedString {
        NSAttributedString(string: self, style: style)
    }
}