chore(general): bump MSRV to 1.81, use core::error::Error on no-std compatible crates
#1552
+14
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
…r` on no-std compatible crates For `no-std` compatible crates, we can use `core::error::Error` instead of `std::error::Error` to avoid gating the Error impl under `std`.
Evalir
force-pushed
the
evalir/impl-core-error
branch
from
8c0de62
to
1ebb429
Compare
|
I'm ok with bumping MSRV for this since it's in line with our policy. Do you want to do this in alloy-core too? |
|
Yep, happy to do it on alloy core too. Sounds good! |
|
@DaniPopes i've not removed any Core PR: alloy-rs/core#780 |
Evalir
changed the title
impl core::error::Error instead of impl std::error::Error on no-std compatible cratescore::error::Error on no-std compatible crates
Closed
tcoratger
reviewed
Oct 23, 2024
| @@ -124,7 +124,7 @@ When updating this, also update: | |||
| - .github/workflows/ci.yml | |||
| --> | |||
|
|
|||
| The current MSRV (minimum supported rust version) is 1.79. | |||
| The current MSRV (minimum supported rust version) is 1.81. | |||
|
|
|||
| Alloy will keep a rolling MSRV policy of **at least** two versions behind the | |||
There was a problem hiding this comment.
Maybe we should remove this comment as it is not true anymore no?
There was a problem hiding this comment.
Ah oops I thought the latest stable was 1.83. We should wait on this until the next version.
3 tasks
zerosnacks
added
the
blocked
|
Added a temporary blocked label as it relies on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For
no-stdcompatible crates, we can usecore::error::Errorinstead ofstd::error::Errorto avoid gating the Error impl understdfor the impl blocks.Solution
replace
std::error::Errorwithcore::error::Erroron the impl blocks.PR Checklist