feat: allo v2.1 deployment script #660
Conversation
There was a problem hiding this comment.
In #658 I created DeployBase.sol, do you think you can make use of it?
Also, @0xOneTony suggested to set the deploy vars on the .env so it's easier to change and deploy, and I think here makes even more sense since the variables barely change within chains. wdyt?
There was a problem hiding this comment.
- Inheriting from
DeployBase.solallo-protocol@5f983c1
I'm not sure about moving vars to .env. Why would that be easier? Deploying on different chains would require you change the .env deployment vars instead of simply calling bun run deploy-allo-v2.1 <CHAIN>, right? It would also make it more difficult to deploy to N chains in loop if that was necessary.
There was a problem hiding this comment.
Well actually I could move the _getAlloParams() logic in DeployAllo.sol to deployAllo.sh and assign .env vars there. I could do that if you think it's better.
No description provided.