test(medusa): multiple strat #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didn't include the superfluid one, as it's relying on Superfluid |
0xRaccoon
reviewed
Oct 24, 2024
| uint256[] internal ghost_poolIds; | ||
| mapping(uint256 _poolId => address _poolAdmin) ghost_poolAdmins; | ||
|
|
||
| // mapping(uint256 _poolId => PoolStrategies _strategy) internal _poolStrategy; |
0xRaccoon
reviewed
Oct 24, 2024
| mapping(PoolStrategies _strategy => address _implementation) | ||
| internal _strategyImplementations; | ||
|
|
||
| function _initImplementations(address _allo) internal { |
0xRaccoon
reviewed
Oct 24, 2024
| } | ||
|
|
||
| function _recordPool(uint256 _poolId, PoolStrategies _strategy) internal { | ||
| // _poolStrategy[_poolId] = _strategy; |
0xRaccoon
reviewed
Oct 24, 2024
| emit TestFailure("Wrong pool strategy implementation address"); | ||
| } | ||
|
|
||
| function _strategyHasImplementation( |
There was a problem hiding this comment.
another option is to use an aux mapping(PoolStrategies strategy => address implementation) to avoid the for loop
There was a problem hiding this comment.
as we are not optimising for gas, I think we should avoid as much as possible having state in the test contract, when we can easily(ish) compute it instead - wdyt?
0xRaccoon
reviewed
Oct 24, 2024
test/invariant/fuzz/Setup.t.sol
Outdated
| // Deploy strategies implementations | ||
| _initImplementations(address(allo)); | ||
|
|
||
| // strategy_directAllocation = new DirectAllocationStrategy(address(allo)); |
0xRaccoon
reviewed
Oct 24, 2024
| DEFAULT_MAX_BID = 1000; | ||
|
|
||
| for (uint256 i = 1; i <= uint256(type(PoolStrategies).max); i++) { | ||
| address _deployer = _ghost_actors[i % 4]; |
There was a problem hiding this comment.
why is it % 4 ? if we are interested to use a specific address we could mark it explicitly just in case _ghost_actors is changed in the future
There was a problem hiding this comment.
the first 4 actors are anchor owner, no?
0xRaccoon
reviewed
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.