Stop hardcoding libc soname #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no porter boxes for these two arches. I tested this on x86 by flipping the imports, i.e. trying to import 6.1 first. |
|
ia64 and alpha? srsly? |
allisonkarlitskaya
requested changes
Dec 13, 2024
ia64/alpha has SONAME "libc.so.6.1" `None` works because Python is linked against libc, so the symbol is already in our address space. See cockpit-project/cockpit#21396
|
ia64 got scrapped, but alpha is still a thing ... Thanks for the hint! Done. |
allisonkarlitskaya
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ia64/alpha has SONAME "libc.so.6.1"
Noneworks because Python is linked against libc, so the symbol is already in our address space.See cockpit-project/cockpit#21396