Fix invalid array index causing assertion.

Bug: issue #895 Test: new test case
alliedmodders · Nov 29, 2023 · c96fab0 · c96fab0
1 parent 5f87e3c
commit c96fab0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/compiler/semantics.cpp b/compiler/semantics.cpp
@@ -1451,8 +1451,8 @@ bool Semantics::CheckIndexExpr(IndexExpr* expr) {
         report(base, 29);
         return false;
     }
-    if (base_val.sym->ident() != iARRAY && base_val.sym->ident() != iREFARRAY) {
-        report(base, 28) << base_val.sym->name();
+    if (base_val.ident != iARRAY && base_val.ident != iREFARRAY) {
+        report(index, 28) << base_val.sym->name();
         return false;
     }
 

diff --git a/tests/compile-only/fail-array-extra-indices.sp b/tests/compile-only/fail-array-extra-indices.sp
@@ -0,0 +1,13 @@
+enum struct A
+{
+    int b[1];
+}
+
+public void main()
+{
+    A a;
+    a.b[0] = 0;
+    a.b[0][0] = 0;
+    a.b[0][0][0] = 0;
+    a.b[0][0][0][0] = 0;
+}
diff --git a/tests/compile-only/fail-array-extra-indices.txt b/tests/compile-only/fail-array-extra-indices.txt
@@ -0,0 +1,3 @@
+(10) : error 028: invalid subscript (not an array or too many subscripts): "b"
+(11) : error 028: invalid subscript (not an array or too many subscripts): "b"
+(12) : error 028: invalid subscript (not an array or too many subscripts): "b"