Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Band-aid for Bulk SDKHooks performance impact #2 #2094

Merged
merged 3 commits into from
May 18, 2024

Conversation

KaelaSavia
Copy link
Contributor

Resolves previously mentioned issues in original pull #2092

Apologies for closing previous one, was going on abruptly planned holidays but decided to grab laptop anyhow so if there are any further issues i'll be able to work further on PR 😅

@KyleSanderson
Copy link
Member

KyleSanderson commented Dec 10, 2023

it's the same branch... reopening the old one.

ugh. comments in the other PR. Mostly around just tighter levelend code.

Copy link
Member

@KyleSanderson KyleSanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, @Headline can you test then merge.

@Jugheadbomb
Copy link

Any progress on testing and mergin this?

@Rushaway
Copy link
Contributor

Rushaway commented Feb 6, 2024

This patch is making a significant difference after multiple tests, thank you for it.

@KaelaSavia
Copy link
Contributor Author

@Headline Any potential ETA for testing or any way I could help with testing to speed process-up?

I personally along with other people in comments so far tested change and have experienced no issues and only performance improvements!

  • Thanks

@Rushaway
Copy link
Contributor

Rushaway commented Feb 6, 2024

Based on the map in #1935 , ported for CS:S
Without alliedmodders/metamod-source@f2d9d3e server make a big timeout for 10s at every round start.

Based on the same machine, configs, hardware, os, metamod version (latest).
Using SM 1.12 build 6954:
Here some results:

Stock SM:

4191 frames sampled for 28.60 seconds
Average 146.53 fps, 6.82 ms per frame
Peak 134.12 ms frame
99 pct of time accounted for

This commit patch:

MM:S 1.12.0-dev+1192 (speed up by 42.7%.)

4195 frames sampled for 28.56 seconds
Average 146.89 fps, 6.81 ms per frame
Peak 76.90 ms frame
99 pct of time accounted for

MM:S 1.11.0-dev+1155 (speed up by 46.52%.)
(improvement come from f2d9d3e)

4195 frames sampled for 28.63 seconds
Average 146.57 fps, 6.82 ms per frame
Peak 71.73 ms frame
99 pct of time accounted for

Stock: profiler__2024-02-06_18-01-09.log
Band Aid patch with MM 1.12: profiler__2024-02-06_19-43-26.log
Band Aid patch with MM 1.11 (including f2d9d3e) :profiler__2024-05-18_11-11-48.log

@Rushaway
Copy link
Contributor

I uptaded my preivous message with the difference related to MetaMod:Source with and without Replace fscanf with faster parsing commit. It also make a nice difference.

@KyleSanderson KyleSanderson merged commit e373480 into alliedmodders:master May 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants