Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkout token to support private repos #353

Merged
merged 5 commits into from
Jan 13, 2024

Conversation

szinn
Copy link
Contributor

@szinn szinn commented Oct 13, 2023

Flux-diff is not able to pull the repo if it is a private repo. Adding a token to the checkout action appears to resolve that issue.

@allenporter
Copy link
Owner

I may need to run the github workflow at an older version. Let me work on that to fix CI.

@szinn
Copy link
Contributor Author

szinn commented Oct 13, 2023

I wonder if this is a log in to gh?

@allenporter allenporter changed the title Add checkout token Add checkout token to support private repos Oct 14, 2023
@allenporter
Copy link
Owner

I'm not really understanding the action failures here. Are they a result of this change?

Copy link
Owner

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the tests pass with the default value unset?

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e76c0fe) 93.45% compared to head (a355fc7) 93.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          19       19           
  Lines        1972     1972           
=======================================
  Hits         1843     1843           
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyriis
Copy link

tyriis commented Jan 13, 2024

@szinn @allenporter, what needs to be done to fix this? (when setting the default to '') it works for me, I have opened a pr, but looks like there is an issue with the test setup.

@yalait
Copy link

yalait commented Jan 13, 2024

Right here fix problems
szinn#2

Copy link
Owner

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved the merge conflict and re-ran the tests and things look good.

@allenporter allenporter merged commit 4c6d07c into allenporter:main Jan 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants