-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkout token to support private repos #353
Conversation
I may need to run the github workflow at an older version. Let me work on that to fix CI. |
I wonder if this is a log in to gh? |
I'm not really understanding the action failures here. Are they a result of this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the tests pass with the default value unset?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 19 19
Lines 1972 1972
=======================================
Hits 1843 1843
Misses 129 129 ☔ View full report in Codecov by Sentry. |
@szinn @allenporter, what needs to be done to fix this? (when setting the default to '') it works for me, I have opened a pr, but looks like there is an issue with the test setup. |
Right here fix problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved the merge conflict and re-ran the tests and things look good.
Flux-diff is not able to pull the repo if it is a private repo. Adding a token to the checkout action appears to resolve that issue.