Support for generate_request_id and preserve_external_request_id listener config #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piorkowskiprzemyslaw
changed the title
|
LGTM, just add some test which checks x-request-id header behaviour. |
pzmi
approved these changes
Jan 11, 2021
lukidzi
approved these changes
Jan 11, 2021
slonka
approved these changes
Jan 11, 2021
| import pl.allegro.tech.servicemesh.envoycontrol.config.service.HttpsEchoContainer | ||
| import pl.allegro.tech.servicemesh.envoycontrol.config.service.HttpsEchoResponse | ||
|
|
||
| fun ObjectAssert<HttpsEchoResponse>.isOk(): ObjectAssert<HttpsEchoResponse> { |
There was a problem hiding this comment.
We already have this for the response, duplicating this seems a bit odd but it's not that much code anyway.
| // given | ||
| val requestIdHeader = mapOf("x-request-id" to "egress-fake-request-id") | ||
|
|
||
| untilAsserted { |
There was a problem hiding this comment.
I think we should decide on a "standard method" for this type of tests. I think that everything except reliability tests should use waitForReadyServices. WDYT?
There was a problem hiding this comment.
I agree. However, I'd change it in a separate PR. I want to merge it ASAP and I don't want to make changes to someone else's PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.