-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpenAPI Generator #35
base: main
Are you sure you want to change the base?
Conversation
#!/bin/bash | ||
cd $(dirname $0) | ||
|
||
./APIGeneration/make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an extra script for the generation? Am I missing something or could this be simplified to one script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it makes sense to have everything generation related in an own folder and this script is just for convenience from the root folder - we can also move everything in here if you want
README.md
Outdated
brew install openapi-generator | ||
``` | ||
|
||
Configuration can be edited in `APIGeneration/generator-config.json`, `APIGeneration/make` and `APIGeneration/.openapi-generator-ignore` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add instructions on how to execute the model generation
I think we should also exclude the generated models from the swiftlint step - this can be done in the swiftlint config file |
@fgeistert |
No description provided.