-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional functionality to util package #136
Open
mwieser
wants to merge
19
commits into
master
Choose a base branch
from
mwr/backport
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MIME interface to use mimtype.MIME or an already KnownMIME - Add function to detach context to avoid context cancelation. Can be used to pass context information to go routines without a deadline or cancel - Add oauth2 helper for PKCE extention
- Extend mailer mock to support waiting for all expected mails to arrive to test mails sent in go routines
…rter into mwr/backport
….MIME Fixed names of some util methods
MorpheusXAUT
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 62.86% 63.80% +0.94%
==========================================
Files 78 86 +8
Lines 6053 6239 +186
==========================================
+ Hits 3805 3981 +176
- Misses 1635 1643 +8
- Partials 613 615 +2
☔ View full report in Codecov by Sentry. |
# Conflicts: # CHANGELOG.md # go.mod # internal/config/server_config.go # internal/util/string.go
add tests in util package
…m for slices instead of passing each item as arg. sqlboiler fails at about 10k params because database and driver limits are reached. With this slices with over 1kk entries are working.
…zed while debugging
anjankow
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg.StringArray
to support more arguments