Skip to content

Commit

Permalink
codeowners + workflow diff python2/3
Browse files Browse the repository at this point in the history
  • Loading branch information
leonardbinet committed Jun 21, 2020
1 parent bb8976e commit 3401a76
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @alk-lbinet
39 changes: 39 additions & 0 deletions .github/workflows/python-2-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Python 2 Tests

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest
strategy:
matrix:
python-version: [2.7]

steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements-test-2.txt
python setup.py develop
- name: Lint with flake8
run: |
# ignore "line break before binary operator", and "invalid escape sequence '\_'" useful for doc
flake8 --count --ignore=W503,W605 --show-source --statistics pandagg
# on tests, more laxist: allow "missing whitespace after ','" and "line too long"
flake8 --count --ignore=W503,W605,E231,E501 --show-source --statistics tests
- name: Test with pytest
run: |
pytest
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Python package
name: Python 3 Tests

on:
push:
Expand All @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [2.7, 3.5, 3.6, 3.7, 3.8]
python-version: [3.5, 3.6, 3.7, 3.8]

steps:
- uses: actions/checkout@v2
Expand Down
7 changes: 7 additions & 0 deletions requirements-test-2.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
flake8
coverage
pytest
# last mock version compatible with P2 (will drop constraint when removing support for P2)
mock<=3.0.5
# idem, last pandas compatible version with P2
pandas<=0.23.1
6 changes: 2 additions & 4 deletions requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
flake8
coverage
pytest
# last mock version compatible with P2 (will drop constraint when removing support for P2)
mock<=3.0.5
# idem, last pandas compatible version with P2
pandas<=0.23.1
mock
pandas

0 comments on commit 3401a76

Please sign in to comment.