-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump some system info on error #885
Conversation
alibuild_helpers/build.py
Outdated
safe_args = { | ||
"pkgname", "defaults", "architecture", "forceUnknownArch", | ||
"develPrefix", "jobs", "noSystem", "noDevel", "forceTracked", "plugin", | ||
"disable", "annotate", "onlyDeps", "docker", "docker_extra_args", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we potentially have password based authentication possible via docker_extra_args, remote store?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, losing the remote store hurts... I might make a follow-up PR that displays the kind of remote store at least
Removing them both
Updated output example:
|
e932618
to
faa4cb5
Compare
faa4cb5
to
a698c64
Compare
Should make debugging logs easier
Still left to implement:@ktf do you agree with the safe_args list? I think none should be leaking any secrets, but maybe docker_extra_args can?
Example output: