Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alibuild recipe (reference) : requirements #771

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maireiphc
Copy link
Contributor

Adding extra details about the logic I understood for the fields :

  • requires,
  • build_requires,
  • runtime_requires

This comes after some mail exchanges with Adrian Sevcenco, Giulio Eulisse + some local tests on one alidist recipe (lhapdf.sh).
To be revised by Giulio to make sure that this is correct.

Adding extra details about the logic I understood for the fields : requires, build_requires, runtime_requires
(after mail exchanges with Adrian Sevcenco, Giulio Eulisse + some local tests on one alidist recipe (lhapdf.sh).
To be revised by Giulio to make sure that this is correct.
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #771 (4ab92a1) into master (09a707a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          29       29           
  Lines        2984     2984           
=======================================
  Hits         2603     2603           
  Misses        381      381           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ktf
Copy link
Member

ktf commented Aug 11, 2022

Thank you for this. We should probably check the the runtime_requires behave correctly. I do no think we ever used them...

@maireiphc
Copy link
Contributor Author

I confess that I discovered the runtime_requires feature by re-reading your text a few hours ago (in the env variables).
I extrapolated the text, I did not test the thing.
I have been so far unaware of such a thing to exist. I indeed never stumbled upon runtime_requires in any recipe. At the moment, there is no occurrence of it among our alidist recipes.

Comment on lines 135 to 136
the "required" corresponding binaries, libraries and environment variables
will be made available (by loading the dependency module) before the current built starts.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you confirm that a requires or build_requires load the dependency module before the build starts ?
I mean, it is a "casual" loading of module, there is nothing extra or specific (bin, lib, env) due to the fact that we are about to compile a new package ? In other words, loading a module, be it for a coming built-time or run-time, is the same ?
(I was not sure about this).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the dependency module, they load the build environment of the dependencies. aliBuild has no idea about modulefiles.

Apparently it is not the full module of the dependency which is loaded before the build requiring it starts, it is the build environment only.
Update of the TOC to match the section content (build env, runtime env, ...)
@singiamtel
Copy link
Collaborator

Marking this as draft, as the CI builder errors out without the changes in #789

If there's still interest to get this merged, could you rebase this on master? The file is now located at docs/docs/reference.md

@singiamtel singiamtel marked this pull request as draft August 29, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants