Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on bc being installed #1271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not depend on bc being installed #1271

wants to merge 1 commit into from

Conversation

ktf
Copy link
Member

@ktf ktf commented Nov 22, 2023

No description provided.

@ktf
Copy link
Member Author

ktf commented Nov 22, 2023

@TimoWilken could you cross check?
@sy-c I guess we do not need the RPMs for DA anymore...

@sy-c
Copy link
Contributor

sy-c commented Nov 22, 2023

@sy-c I guess we do not need the RPMs for DA anymore...

I hope so, I have not seen one for the past 5 years ;) please go ahead and cleanup related features as you need !

@ktf
Copy link
Member Author

ktf commented Nov 22, 2023

That's the answer I wanted... ;-)

@TimoWilken
Copy link
Contributor

Do we need this BUILD_DATE calculation anyway?

As far as I can tell, it creates a new build area every 3 days (not sure why), then later in the script it loops through all the build areas to find its own one (the $WORKAREA/$WORKAREA_INDEX/current_slave stuff), I guess to deconflict different "build slots"/executors on the same builder (why not use Jenkins' $EXECUTOR_NUMBER variable?).

If we want a new build area every once in a while, why not e.g. date -u '+%Y-%m-%d' for a new one every day or date -u '+%Y-W%W' for once a week?

If you want to keep the logic as-is, I'd remove the extra wrapping $(echo ...):

BUILD_DATE=2015$(("$(date -u +%s)" / 86400 / 3))

@ktf
Copy link
Member Author

ktf commented Nov 22, 2023

No, indeed we can probably drop everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants