Add test for building on an air-gapped system #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
requested changes
Sep 20, 2024
There was a problem hiding this comment.
The test is essentially OK but please fix these minor comments.
@Fabien-Chouteau, I guess you need to review this one too.
testsuite/tests/workflows/air-gapping/my_index/crates/hello/HEAD
Outdated
Show resolved
Hide resolved
|
Hi Alejandro,
You don't need my reviews for @Seb-MCaw 's contributions :) |
OK, noted. |
mosteo
approved these changes
Sep 24, 2024
|
Merged, thanks! |
mosteo
pushed a commit
to mosteo/alire
that referenced
this pull request
Oct 8, 2024
* Add test for offline build * Move constraints to YAML file * Remove redundant build check * Change crates from git repos to .tgz archives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently interested in the possibility of using Alire on an air-gapped system. The idea would be to fetch a crate and its dependencies online, then transfer to an offline system/network before building.
alr getandalr buildseem to already implement the necessary functionality, so this PR simply adds a test to verify the process works as expected.