Fix bugs causing spurious diffs on updates without changes #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solutions were the same, but some types internally where using pointers instead of pointed objects for comparison. WIP
Fabien-Chouteau
approved these changes
Jan 29, 2024
| @@ -31,7 +31,14 @@ abstract project Alire_Common is | |||
| "-gnatyu", -- no unnecessary blank lines | |||
| "-gnatyx", -- no extra parens around conditionals | |||
| "-gnaty-s"); -- relax fwd decl | |||
| when "disabled" => Style_Check_Switches := (); | |||
| when "disabled" => Style_Check_Switches := | |||
| ("-gnat2022", | |||
There was a problem hiding this comment.
I don't think it's good to change language version when disabling style checks.
I fear this is going to have unexpected consequences that will make your life harder.
There was a problem hiding this comment.
Let's make it a separate scenario then. In any case all of our checks have checks enabled so it shouldn't slip through.
Fabien-Chouteau
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types internally where using pointers instead of pointed objects for comparison.
Fixes unrelated bug in dealing with empty error messages (we never generate those, but some Ada 2022 'Image do).
Fixes #1278