Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print UTF-8 string using GNAT.IO in Report_Jekyll #1457

Closed
wants to merge 0 commits into from

Conversation

mgrojo
Copy link
Contributor

@mgrojo mgrojo commented Sep 17, 2023

Fixes #1456

@mgrojo
Copy link
Contributor Author

mgrojo commented Sep 17, 2023

Another possibility is changing this renames to GNAT.IO, but I didn't know the implications. Maybe you think it's better because it could solve other UTF-8 problems.

procedure Put_Line (S : String)
renames Ada.Text_IO.Put_Line;

@mosteo
Copy link
Member

mosteo commented Sep 18, 2023

Thanks for spotting this, @mgrojo . No matter the implications, the proper way to output UTF-8 is unencoded via Wide_Wide_Text_IO, or encoded directly through GNAT.IO.

Text_IO should not be used and this renaming slipped through the cracks during #972, #1220, #1332.

So I'd ask you if it's not too much trouble to fix the rename instead of using explicitly GNAT.IO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alr show --jekyll zeromq_ada prints garbage from special character and truncates output
2 participants