Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elogs 1.1.0 #957

Merged
merged 12 commits into from
Feb 16, 2024
Merged

elogs 1.1.0 #957

merged 12 commits into from
Feb 16, 2024

Conversation

kevlar700
Copy link
Contributor

No description provided.

@mosteo
Copy link
Member

mosteo commented Jan 15, 2024

Hi @kevlar700 , the tests are not running because the submitted file is at the wrong path: upload/stable-1.2.1/index/el/elogs

It should be at index/el/elogs-1.1.0.toml.

You can move the file to the proper location, commit and push in this same PR.

@mosteo
Copy link
Member

mosteo commented Jan 16, 2024

Now the file has the correct name, but is still in the wrong location. The upload/stable-1.2.1 should not be there, it should be directly start at index.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the delete button was hidden. I didn't see the menu scroll bar for ages.

@kevlar700
Copy link
Contributor Author

What is the issue now @mosteo ?

@mosteo
Copy link
Member

mosteo commented Feb 15, 2024

Compilation is failing at the new [] arrays, you should enable Ada 2022 features with

[build-switches]
"*".ada_version = "Ada2022"

in the manifest.

@kevlar700
Copy link
Contributor Author

kevlar700 commented Feb 15, 2024

in the manifest.

Do I need to remove -gnat2022 from here now? Does that require a new PR?
https://github.com/kevlar700/elogs/blob/main/config/elogs_config.gpr

Edit: I tried removing it but I see now that the failed LTS checks use a distro toolchain that doesn't support 2022. Not sure what is happening with alr dev.

A pretty cool set of checks :)

@mosteo
Copy link
Member

mosteo commented Feb 16, 2024

Do I need to remove -gnat2022 from here now? Does that require a new PR?

The config dir is regenerated by alr on any changes to the manifest, so you can leave it as is. You could even leave it out of version control, although leaving it in allows the use of your project without Alire.

toolchain that doesn't support 2022

This means you need a minimum compiler version dependency. I'll add that one because I also have to deal with the error with compiling the master branch; bizarrely I suspect a PR intended to ensure wide compiler compatibility may have introduced that regression.

So I think you're done, thanks for the patience

@mosteo
Copy link
Member

mosteo commented Feb 16, 2024

Remaining checks should succeed after alire-project/alire#1566 is merged

@mosteo mosteo merged commit eb5beb5 into alire-project:stable-1.2.1 Feb 16, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants