Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for gprbuild from system provider. #913

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Don't look for gprbuild from system provider. #913

merged 2 commits into from
Nov 9, 2023

Conversation

simonjwright
Copy link
Contributor

Because the manifest currently asks for Alire to try to download gprbuild from the system package manager, alr spends several fruitless seconds trying to find gprbuild. This PR removes the 'system' external from gprbuild-external.toml.

Because the manifest currently asks for Alire to attempt to download
gprbuild from the system package manager, alr <anything> spends
several fruitless seconds trying to find gprbuild.

  * index/gp/gprbuild/gprbuild-external.toml: remove the 'system' external.
@simonjwright
Copy link
Contributor Author

simonjwright commented Nov 1, 2023

I see that Debian and Msys do provide gprbuild. Should I just make the load conditional on the "os" not being macOS? or the "distribution" not being HomeBrew, MacPorts? (not sure how to do either)

@mosteo
Copy link
Member

mosteo commented Nov 2, 2023

For the time being I think it's OK to use the OS for the conditional.

  * index/gp/gprbuild/gprbuild-external.toml: the "system" external isn't
    available on macOS, so specify it explicitly for the other operating
    systems.
@mosteo mosteo merged commit df12ae1 into alire-project:stable-1.2.1 Nov 9, 2023
15 checks passed
@simonjwright simonjwright deleted the gprbuild-not-in-provider branch November 9, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants