pico_ultrasonic_ranger 0.1.0 #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
reviewed
Dec 16, 2024
| @@ -0,0 +1,18 @@ | |||
| name = "pico_ultrasonic_ranger" | |||
| description = "Driver for the Grove ultrasonic ranger. Depends on the RP Pico HAL." | |||
There was a problem hiding this comment.
Would it be better that grove appears in the crate name? E.g. grove_pico_ultrasonic_ranger
There was a problem hiding this comment.
I thought of that, but the driver may work also with the Adafruit or Sparkfun rangers, therefore I decided not to add Grove in the crate name.
mosteo
approved these changes
Dec 17, 2024
|
This is still in draft mode, OK to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created via
alr publishwithalr 2.0.2+9b80158