Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a0b_i2c 0.1.0 #1249

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

godunko
Copy link
Contributor

@godunko godunko commented Oct 17, 2024

Created via alr publish with alr 2.0.2+9b80158

@godunko godunko marked this pull request as ready for review October 17, 2024 13:06
@godunko godunko force-pushed the release/a0b_i2c-0.1.0 branch from f11efde to 29d8d1a Compare October 21, 2024 07:00
@godunko
Copy link
Contributor Author

godunko commented Oct 21, 2024

Selftest requires arm-eabi target and light-cortex-m0 runtime, it seems they are not provided by Ubuntu/Debian distro toolchains, and Alire's GNAT is not used for some reason.

Is there some combination of target/runtime that is present on all platforms?

Or is there some configuration parameters to skip builds with distro toolchain in CI?

@mosteo
Copy link
Member

mosteo commented Oct 21, 2024

On cursory look, the failure seems to be that the cross-compiler is installed but the compatible gprbuild, so the distro-provided one is unable to find the compiler. That's for me to fix.

@godunko
Copy link
Contributor Author

godunko commented Oct 21, 2024

Thanks!

I've submitted one more MR (#1255) and CI works fine on it. The difference is that a0b_stm32f401 crate has gnat_arm_elf in dependencies, while a0b_i2c crate doesn't have such dependency and it added by the selftest subcrate.

@mosteo
Copy link
Member

mosteo commented Oct 21, 2024

The difference is that a0b_stm32f401 crate has gnat_arm_elf in dependencies, while a0b_i2c crate doesn't have such dependency and it added by the selftest subcrate.

Right. The CI check isn't clever enough to know where tests are and doesn't proactively install gprbuild. A workaround for the time being would be to add a dependency on gprbuild in the testing crate itself, besides on gnat. Still, I want to have a proper solution to this (but you may try it if you want).

@godunko godunko force-pushed the release/a0b_i2c-0.1.0 branch from 29d8d1a to 0ce3fc4 Compare October 21, 2024 11:26
@godunko
Copy link
Contributor Author

godunko commented Oct 21, 2024

Adding of

gprbuild = "*"

has undesirable side effect on my setup, it attempts to install gprbuild provided by the system (Ubuntu 22.04), and not provided by Alire :( Adding of

gprbuild = "^22.0.1"

works on my side, but it seems CI fails on MacOS.

@mosteo
Copy link
Member

mosteo commented Oct 21, 2024

I see. This is because only the latest toolchains work on the latest macOS ARM runners.

Let me see if I can come up with a general fix. If you want the crates merged already, given that we know the issue is unrelated, I can merge them so you don't have to wait.

@godunko godunko force-pushed the release/a0b_i2c-0.1.0 branch from 6469bb3 to 0ce3fc4 Compare October 21, 2024 12:45
@godunko
Copy link
Contributor Author

godunko commented Oct 21, 2024

Up to you, I can wait for few days, I have more crates to add selftests and to prepare MRs.

@godunko godunko force-pushed the release/a0b_i2c-0.1.0 branch from 0ce3fc4 to 8279aca Compare October 21, 2024 12:58
@mosteo
Copy link
Member

mosteo commented Oct 21, 2024

This issue should be fixed for the future, I hope. Thanks for the patience.

@mosteo mosteo merged commit 3e415ae into alire-project:stable-1.3.0 Oct 21, 2024
18 checks passed
@godunko godunko deleted the release/a0b_i2c-0.1.0 branch October 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants