Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gprbuild 24.0 with Mac OS M1 #1119

Merged

Conversation

reznikmm
Copy link
Contributor

No description provided.

Comment on lines +4 to +5
maintainers = ["[email protected]"]
maintainers-logins = ["Fabien-Chouteau"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reznikmm @Fabien-Chouteau Should @reznikmm be added here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection to append me to maintainers list. But I don't think I can make big contribution here.

@reznikmm
Copy link
Contributor Author

I've tested this gprbuild 24.0 with my ada_language_server GitHub CI. It's able to build shared and static libraries, executables for Linux x86_64, MacOS X x86_64/AArch64. I would like to use it from the community index.

@mosteo
Copy link
Member

mosteo commented Jul 29, 2024

@Fabien-Chouteau is it OK to add this build of gprbuild to our repertoire?

@Fabien-Chouteau
Copy link
Member

@Fabien-Chouteau is it OK to add this build of gprbuild to our repertoire?

If Max tested it then yes.

@Fabien-Chouteau Fabien-Chouteau merged commit e620290 into alire-project:stable-1.3.0 Jul 29, 2024
14 of 15 checks passed
@mosteo
Copy link
Member

mosteo commented Jul 31, 2024

Hi @reznikmm, this release introduced the regression described in alire-project/GNAT-FSF-builds#71 (comment)

I missed that this PR was adding all the builds for v24, at some point I started thinking it only added the ARM64 build. So this will affect people generally.

We have a rule against pulling releases from the index, but in this case I'm not so sure... Unless a fix can be released quickly, I'd rather pull this down for the time being.

@Fabien-Chouteau
Copy link
Member

We should remove it, unfortunately, as we won't be able to fix it quickly. What will be the consequences for users if they selected this a default GPRbuild?

@mosteo
Copy link
Member

mosteo commented Aug 1, 2024

It seems to fail at linking time when using dynamic libraries, but only for executables.

By default, with recent crates or libraries that do not bother to modify defaults in the gpr file, it seems to work normally.

Also, when building a library it also succeeds, even if the library depends on other ones. It's only when linking a final executable that it fails (in my limited testing).

@reznikmm
Copy link
Contributor Author

reznikmm commented Aug 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants