Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pragmarc 1.0.0 #1114

Closed

Conversation

bracke
Copy link
Contributor

@bracke bracke commented Jul 8, 2024

Created via alr publish with alr 2.0.1

@bracke bracke marked this pull request as ready for review July 8, 2024 15:25
@mosteo
Copy link
Member

mosteo commented Jul 8, 2024

Hi @bracke , have you agreed with @jrcarter on the versioning numbers here? I think he's simply using the date for releases.

@bracke
Copy link
Contributor Author

bracke commented Jul 8, 2024

No, we have not talked about versioning.
Would a date even be useable in Alire?

@zertovitch
Copy link
Contributor

@mosteo
Copy link
Member

mosteo commented Jul 9, 2024

No, we have not talked about versioning. Would a date even be useable in Alire?

Then, I'd very much prefer if the version matched, as @zertovitch exemplified, the tag from which this release is taken (assuming you're using one of @jrcarter's tagged releases).

@bracke
Copy link
Contributor Author

bracke commented Jul 9, 2024

Then, I'd very much prefer if the version matched, as @zertovitch exemplified,
the tag from which this release is taken (assuming you're using one of @jrcarter's tagged releases).

I'm using the default branch, which seems to be the tag v20240323.
I have changed the version to v20240323.

@@ -0,0 +1,22 @@
name = "pragmarc"
description = "The PragmAda Reusable Components"
version = "v20240323"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v should be removed, and the file renamed to match the version, to pragmarc-20240323.0.0.toml.

@bracke bracke closed this Jul 10, 2024
@bracke bracke deleted the release/pragmarc-1.0.0 branch July 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants