opentoken 6.0.3 #1100
Merged
opentoken 6.0.3 #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
requested changes
Jul 1, 2024
Comment on lines
14
to
15
| [[depends-on]] | ||
| aunit = "^24.0.0" |
There was a problem hiding this comment.
If this is only used for testing the crate itself, it should not appear here as a dependency for clients. Testing should be moved to a nested crate.
There was a problem hiding this comment.
Hi Lionel, could you clarify about this point? That is, is aunit necessary for opentoken to work?
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
Hi Alex, sorry for the delay, this should be removed.
Lionel
Le 2024-09-12 12:23, Alejandro R Mosteo a écrit :
@mosteo commented on this pull request.
-------------------------
In index/op/opentoken/opentoken-6.0.3.toml [1]:
> +[[depends-on]]
+aunit = "^24.0.0"
Hi Lionel, could you clarify about this point? That is, is aunit
necessary for opentoken to work?
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you authored the thread.Message ID:
***@***.***>
Links:
------
[1]
#1100 (comment)
[2]
https://github.com/notifications/unsubscribe-auth/AH5RMNEQEKMO5RLZPCIIDFDZWFTTLAVCNFSM6AAAAABKCT4L2SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJZHA2TOMBWGM
--=_77688628fdb4b4252ac8727a38fd7e3b
Content-Type: multipart/related;
boundary="=_1a50eb3763d81cd79d0bc3824fd66a9e"
--=_1a50eb3763d81cd79d0bc3824fd66a9e
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset=
=3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=
eva,sans-serif'>
<p id=3D"reply-intro">Hi Alex, sorry for the delay, this should be removed.=
</p>
<p>Lionel</p>
<p>Le 2024-09-12 12:23, Alejandro R Mosteo a écrit :</p>
<blockquote type=3D"cite" style=3D"padding: 0 0.4em; border-left: #1010ff 2=
px solid; margin: 0">
<div id=3D"replybody1">
<p><br /></p>
***@***.***</strong> commented on this pull request.</p>
<hr />
<p>In <a href=3D"#1100 (comment)=
cussion_r1756577985" target=3D"_blank" rel=3D"noopener noreferrer">index/op=
/opentoken/opentoken-6.0.3.toml</a>:</p>
<pre style=3D"color: #555;">> +[[depends-on]]
+aunit =3D "^24.0.0"
</pre>
<p dir=3D"auto">Hi Lionel, could you clarify about this point? That is, is =
<code class=3D"v1notranslate">aunit</code> necessary for opentoken to work?=
</p>
<p style=3D"font-size: small; -webkit-text-size-adjust: none; color: #666;"=
—<br />Reply to this email directly, <a href=3D"https://github.com/a=
lire-project/alire-index/pull/1100#discussion_r1756577985" target=3D"_blank=
" rel=3D"noopener noreferrer">view it on GitHub</a>, or <a href=3D"https://=
github.com/notifications/unsubscribe-auth/AH5RMNEQEKMO5RLZPCIIDFDZWFTTLAVCN=
FSM6AAAAABKCT4L2SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJZHA2T=
OMBWGM" target=3D"_blank" rel=3D"noopener noreferrer">unsubscribe</a>.<br /=
You are receiving this because you authored the thread.<img src=3D"cid:172=
***@***.***" width=3D"1" height=3D"1" /><span sty=
le=3D"color: transparent; font-size: 0; display: none; visibility: hidden; =
overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height=
: 0; mso-hide: all;">Message ID: <span><alire-project/alire-index/pull/1=
100/review/2299857063</span><span>@</span><span>github</span><span>.</span>=
<span>com></span></span></p>
</div>
</blockquote>
<p><br /></p>
</body></html>
…--=_1a50eb3763d81cd79d0bc3824fd66a9e
Content-Transfer-Encoding: base64
Content-ID: ***@***.***>
Content-Type: image/gif;
name=blocked.gif
Content-Disposition: inline;
filename=blocked.gif;
size=118
R0lGODlhZAAyAIAAAPrOzgAAACH5BAAAAAAALAAAAABkADIAAAJNhI+py+0Po5y02ouz3rz7D4bi
SJbmiabqyrbuC8fyTNf2jef6zvf+DwwKh8Si8YhMKpfMpvMJjUqn1Kr1is1qt9yu9wsOi8fksvls
KwAAOw==
--=_1a50eb3763d81cd79d0bc3824fd66a9e--
--=_77688628fdb4b4252ac8727a38fd7e3b--
|
mosteo
approved these changes
Oct 18, 2024
|
Merged, thanks! |
|
Thanks to you for you patience Alex! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created via
alr publishwithalr 2.0.1