Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply label on missing dependencies from workflow #1094

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Jun 18, 2024

This should simplify review and raise awareness on crates that otherwise pass checks. Missing dependencies is not a merge blocker, but we should be able to detect if some wrong dependency is making the release unavailable in all platforms.

@mosteo mosteo force-pushed the fix/missing-deps-no-fail branch from 91f343d to 4bdd1f5 Compare June 18, 2024 13:52
@alire-project alire-project deleted a comment from github-actions bot Jun 18, 2024
@alire-project alire-project deleted a comment from github-actions bot Jun 18, 2024
@alire-project alire-project deleted a comment from github-actions bot Jun 18, 2024
@alire-project alire-project deleted a comment from github-actions bot Jun 18, 2024

This comment was marked as outdated.

@mosteo mosteo force-pushed the fix/missing-deps-no-fail branch from 4bdd1f5 to acf54a0 Compare June 18, 2024 14:33

This comment was marked as outdated.

Copy link

Workflow Build Crate (Alire toolchain) / : missing dependencies

1 similar comment
Copy link

Workflow Build Crate (Alire toolchain) / : missing dependencies

Copy link

Workflow Build Crate (alr dev) / : missing dependencies

Copy link

Workflow Build Crate (MacPorts) / : missing dependencies

Copy link

Workflow Build Crate (alr dev) / : missing dependencies

This comment was marked as outdated.

@mosteo mosteo force-pushed the fix/missing-deps-no-fail branch from acf54a0 to 7940113 Compare June 18, 2024 14:38
Copy link

Workflow Build Crate (Alire toolchain) / ubuntu-latest: missing dependencies

Copy link

Workflow Build Crate (alr dev) / ubuntu-latest: missing dependencies

Copy link

Workflow Build Crate (alr dev) / macos-12: missing dependencies

Copy link

Workflow Build Crate (Alire toolchain) / macos-12: missing dependencies

Copy link

Workflow Build Crate (MacPorts) / macos-12: missing dependencies

Copy link

Workflow Build Crate (Alire toolchain) / windows-latest: missing dependencies

Copy link

Workflow Build Crate (alr dev) / windows-latest: missing dependencies

@mosteo mosteo force-pushed the fix/missing-deps-no-fail branch from ceac76d to d2a4eb9 Compare June 19, 2024 08:53
@mosteo mosteo changed the title Test applying label/comment to PR from workflow Apply label on missing dependencies from workflow Jun 19, 2024
@mosteo mosteo marked this pull request as ready for review June 19, 2024 09:10
@mosteo mosteo requested a review from a team as a code owner June 19, 2024 09:10
@mosteo mosteo merged commit a56b3a9 into stable-1.3.0 Jun 19, 2024
14 of 15 checks passed
@mosteo mosteo deleted the fix/missing-deps-no-fail branch June 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant