Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asfml 2.6.1 #1077

Merged
merged 1 commit into from
Jul 29, 2024
Merged

asfml 2.6.1 #1077

merged 1 commit into from
Jul 29, 2024

Conversation

mgrojo
Copy link
Contributor

@mgrojo mgrojo commented May 25, 2024

Created via alr publish with alr 2.0.1

@mgrojo
Copy link
Contributor Author

mgrojo commented May 25, 2024

It seems CSFML v2.6.1 is too new for the distributions to be updated. In a case like this, should we wait for inclusion in the Alire index? I think it makes sense the inclusion, since people can always provide a locally installed version of the external library, correct?

@mgrojo mgrojo marked this pull request as ready for review May 25, 2024 19:26
@mosteo
Copy link
Member

mosteo commented May 27, 2024

So there's not a single platform that has a recent enough csfml? How are you testing locally?

@mgrojo
Copy link
Contributor Author

mgrojo commented May 27, 2024

Oh, I'm cloning SFML and CSFML, building them, and I've modified my project files adding for Linker_Options use ("-L../../SFML/SFML/lib", "-L../CSFML/lib", so my compilation takes the latest libraries. Thus, I guess users won't get any benefit of having this in the index before the installation of the external crate can be done by Alire. The only advantage from having this already in the index might be that it will start working when the version is included in the distributions. Maybe it's going to be confusing for users, and it's better if it's only released in my repository until CSFML v2.6.1 is more widespread?

@mosteo
Copy link
Member

mosteo commented May 28, 2024

I see. Yes, for the time being I think it makes more sense to not include it yet in the public index if it requires manual intervention.

Still, I'm rethinking how we should deal here with missing dependencies, rather than failing the workflow outright. Alas, there's no middle way in github actions for now.

@mgrojo
Copy link
Contributor Author

mgrojo commented May 28, 2024

Still, I'm rethinking how we should deal here with missing dependencies, rather than failing the workflow outright. Alas, there's no middle way in github actions for now.

Maybe Action Summaries can help a bit, at least in conveying easily the different results of a failing check?

See example of the Link checker in the awesome-ada repository: https://github.com/ohenley/awesome-ada/actions/runs/8863535503

@mosteo
Copy link
Member

mosteo commented May 30, 2024

Maybe Action Summaries can help a bit, at least in conveying easily the different results of a failing check?

Looks promising! Thanks for the pointer.

@mgrojo mgrojo force-pushed the release/asfml-2.6.1 branch from ad60ead to 997fbcb Compare July 26, 2024 17:01
@mosteo mosteo merged commit 1d5fdbc into alire-project:stable-1.3.0 Jul 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants