Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentoken 6.0.3-dev #1024

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions index/op/opentoken/opentoken-6.0.3-dev.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name = "opentoken"
description = "facility for performing token analysis and parsing within Ada"
version = "6.0.3-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Lionel, you probably want to remove the -dev suffix for a release like this.

Copy link
Contributor Author

@LionelDraghi LionelDraghi Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Fabien,

you're right.
(and if a suffix is needed, -dead would be more appropriate than -dev, as no one (AFAIK) intend to maintain OpenToken :-) )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LionelDraghi If can still change this to a more meaningful value, for instance 6 digit hash of the last commit.


authors = ["Stephen Leake"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is a fork from Stephen's project. Did you get in touch with him to see if he's want to handle publishing on Alire himself?

Copy link
Contributor Author

@LionelDraghi LionelDraghi Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote to Stephen on the first of April, and had no responses.
It was about OpenToken, but not to ask if he wanted to "cratize" his package.
He was very clear in our last conversation back in 2018 that he was not willing to maintain OpenToken. (WisiToken was not officially released at that time, but he was working on it, as far as I remember). I also try at that time to push my updates to the Debian package maintainer, who send me back to Stephen :-)
But you're right, I can email him, and also to the guy who create the GitHub repo by copying the Debian package tree.
I'll tell you.

I wrote to Stephen at stephen_leake at stephe-leake.org, is it the right email adress?
I don't think he is on GithHub...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lionel,

I wrote to Stephen at stephen_leake at stephe-leake.org, is it the right email adress?
I don't think he is on GithHub...

He is actually, and I should've started with that :)

@stephe-ada-guru Are you ok for Lionel to push this release of opentoken on Alire?

Copy link
Contributor Author

@LionelDraghi LionelDraghi May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Fabien,
FYI, just came on this : https://savannah.nongnu.org/news/?id=10538
I hope Stephe is doing well.

(It's just for information, no pressure on opentoken integration on my side, it won't prevent me from releasing others crates)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Fabien,
sorry for my late answer.
Not sure what the 6 digit hash of the last commit is : Is it the result of git rev-parse --short HEAD?
Is version = "6.0.3-2374021" OK for you?
Thanks,
Lionel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the numbers are just to identify the commit, but the version is already "6.0.3", then it should be "6.0.3+2374021", as the "-blah" in semantic versioning means "before the final version".

Copy link
Contributor Author

@LionelDraghi LionelDraghi Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is a fork of https://github.com/JeremPFT/org.opentoken-6.0b
I considered that "6.0b" was the equivalent of "6.0.2" in semver, and then changed it into "6.0.3" because of my own fixes.
I'm not sure adding some suffix to identify the commit make sense here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then just go for 6.0.3, no prob.

maintainers = ["Lionel Draghi <[email protected]>"]
maintainers-logins = ["LionelDraghi"]
licenses = "GPL-3.0-or-later"
website = ""
tags = ["lexer", "parser"]

project-files = ["./build/release/opentoken.gpr"]

[[depends-on]]
aunit = "^24.0.0"

[origin]
commit = "2374021eeb37f3321af22afc728d8d89cbb94d39"
url = "git+https://github.com/LionelDraghi/org.opentoken-6.0c.git"

Loading