Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfss_ada 5.7.0-dev #1023

Closed

Conversation

Irvise
Copy link

@Irvise Irvise commented Apr 5, 2024

Created via alr publish with alr 2.0.1

@Irvise
Copy link
Author

Irvise commented Apr 5, 2024

Please, do not merge this PR! This is just a test to see if what I am doing is actually working!

Also, if you have any feedback, that would be appreciated. Did I do all right? Does the TOML look alright?

Also, it seems that the new "Fine-grained personal access tokens Beta" tokens do not work with Alire even when all the rights are granted. I had to use the classic one for it to work.

Cheers,
Fer

@mgrojo
Copy link
Contributor

mgrojo commented Apr 5, 2024

Is it intentional the removal of the second "l" in the crate name, compared to WolfSSL?

@Irvise
Copy link
Author

Irvise commented Apr 5, 2024

Is it intentional the removal of the second "l" in the crate name, compared to WolfSSL?

Oups! No, it was not intentional. Thank you for finding the issue!

@mosteo
Copy link
Member

mosteo commented Apr 8, 2024

The manifest looks good to me. The problem on Windows seems an easy fix (some bad value for an external variable is used).

@Irvise
Copy link
Author

Irvise commented Apr 8, 2024

The manifest looks good to me. The problem on Windows seems an easy fix (some bad value for an external variable is used).

Yes, the GPRBuild file checks for the "Windows" string variable for the OS. The runner says it is "Windows NT", which GPRBuild cannot match and fails. I will see if I can get it fixed. Thanks

@Irvise Irvise closed this Apr 8, 2024
@mgrojo
Copy link
Contributor

mgrojo commented Aug 3, 2024

@Irvise are you still working on this? I'd like to see WolfSSL in the Alire index, and if you are no longer on it, I'd like to continue the work.

@Irvise
Copy link
Author

Irvise commented Aug 4, 2024

Hola Manuel,

I am still on this, I have not forgotten about it... I want to close WolfSSL's PR regarding Alire first, then maybe I will push this to Alire's index. The crate/project configuration needs to make a couple of other things work out-of-the-box, which they still don't, so that may take a bit longer...

@mgrojo
Copy link
Contributor

mgrojo commented Aug 4, 2024

Hola Fernando,

Perfect. I just wanted to confirm that you still had the intention to get that done. Thanks and have a happy summer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants