-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alr_appimage v0.9.1 compatible with Alire 2.x and Alire 1.x #1011
Conversation
For windows-latest check, it seems that you have to change: C:\Users\runneradmin\AppData\Local\alire\msys64\usr\bin\pacman by C:\Users\runneradmin\AppData\Local\alire\cache\msys64\usr\bin\pacman On the other hand, I didn't expect it to run after the commit changing the availability to be true only on Linux. |
Right, thanks for pointing it out.
Alire must be prepared in advance to be able to check whether the crate is available on the platform, but I see your point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a concern here which is that the name may imply that this comes from the alire-project itself. Also we haven't yet settled how alr
extensions could be packaged and named.
IOW, i'd prefer if this were named appimage_creator
or basically anything not starting with alr_
. (The repo name can stay the same).
After our conversations on alire-project/alire#1352 and my later analysis of what my tool should do, I no longer consider it an extension of
Are we talking here only about the crate name, or also the project and executable name? In any case, Imagine also that I name it I don't mind writing a disclaimer in the crate long description and in the repository readme to clarify the situation. Something like this: Important This tool is not part of, is endorsed by or supported by the Alire nor the AppImage projects, in any way. It is a third-party project intended to help users of both projects. |
I'm only concerned in the context of the project/community index, so more or less what a user would find if doing
I think those are OK. Until (if ever) we have some sort of namespaces, the
Yeah, that was just a low-effort idea 😅
It can't hurt, although if from context the situation is clear, I feel that's up to you. Thanks for the understanding. |
Looking at both git and cargo, it looks like neither of them has this kind of restriction. I understand your concerns @mosteo but I think we have to accept Now @mgrojo is you use that name, you have to know that the Alire project may introduce a |
I'll rename it as |
No description provided.