Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alr_appimage v0.9.1 compatible with Alire 2.x and Alire 1.x #1011

Closed
wants to merge 2 commits into from

Conversation

mgrojo
Copy link
Contributor

@mgrojo mgrojo commented Mar 12, 2024

No description provided.

@mgrojo
Copy link
Contributor Author

mgrojo commented Mar 12, 2024

For windows-latest check, it seems that you have to change:

C:\Users\runneradmin\AppData\Local\alire\msys64\usr\bin\pacman

by

C:\Users\runneradmin\AppData\Local\alire\cache\msys64\usr\bin\pacman

On the other hand, I didn't expect it to run after the commit changing the availability to be true only on Linux.

@mosteo
Copy link
Member

mosteo commented Mar 13, 2024

For windows-latest check, it seems that you have to change:

C:\Users\runneradmin\AppData\Local\alire\msys64\usr\bin\pacman

by

C:\Users\runneradmin\AppData\Local\alire\cache\msys64\usr\bin\pacman

Right, thanks for pointing it out.

On the other hand, I didn't expect it to run after the commit changing the availability to be true only on Linux.

Alire must be prepared in advance to be able to check whether the crate is available on the platform, but I see your point.

Copy link
Member

@mosteo mosteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern here which is that the name may imply that this comes from the alire-project itself. Also we haven't yet settled how alr extensions could be packaged and named.

IOW, i'd prefer if this were named appimage_creator or basically anything not starting with alr_. (The repo name can stay the same).

@mgrojo
Copy link
Contributor Author

mgrojo commented Mar 13, 2024

I have a concern here which is that the name may imply that this comes from the alire-project itself. Also we haven't yet settled how alr extensions could be packaged and named.

After our conversations on alire-project/alire#1352 and my later analysis of what my tool should do, I no longer consider it an extension of alr. It's just a tool that reads your alire.toml, calls alr as a user could manually do, check its exit code, and at the end, gets a result unrelated to Alire. On that regard, it only automates steps using interfaces already provided to the user and which I think will be kept stable for the sake of users, so there's no real need for considering it an extension of the alr tool or Alire in general.

IOW, i'd prefer if this were named appimage_creator or basically anything not starting with alr_. (The repo name can stay the same).

Are we talking here only about the crate name, or also the project and executable name? In any case, appimage_creator, for me, is too unspecific. I'd like the name to convey what the tool is for. What do you think about calling it alr2appimage or alire2appimage?

Imagine also that I name it appimage_creator and the AppImage authors tell me that the name implies that it is an official tool of the AppImage project, and I should rename it. 😉

I don't mind writing a disclaimer in the crate long description and in the repository readme to clarify the situation. Something like this:

Important

This tool is not part of, is endorsed by or supported by the Alire nor the AppImage projects, in any way. It is a third-party project intended to help users of both projects.

@mosteo
Copy link
Member

mosteo commented Mar 14, 2024

Are we talking here only about the crate name, or also the project and executable name?

I'm only concerned in the context of the project/community index, so more or less what a user would find if doing alr search alr or alr search alire. So just the crate name.

In any case, appimage_creator, for me, is too unspecific. I'd like the name to convey what the tool is for. What do you think about calling it alr2appimage or alire2appimage?

I think those are OK. Until (if ever) we have some sort of namespaces, the alr_ is what kind of acts as one.

Imagine also that I name it appimage_creator and the AppImage authors tell me that the name implies that it is an official tool of the AppImage project, and I should rename it. 😉

Yeah, that was just a low-effort idea 😅

I don't mind writing a disclaimer in the crate long description and in the repository readme to clarify the situation.

It can't hurt, although if from context the situation is clear, I feel that's up to you.

Thanks for the understanding.

@Fabien-Chouteau
Copy link
Member

Looking at both git and cargo, it looks like neither of them has this kind of restriction. I understand your concerns @mosteo but I think we have to accept alr.+ and alire.+ crate names.

Now @mgrojo is you use that name, you have to know that the Alire project may introduce a alr appimage command in the future. I don't think it's likely, and we will probably put you in the loop if it happens, but that's a possibility.

@mgrojo
Copy link
Contributor Author

mgrojo commented Mar 14, 2024

I'll rename it as alr2appimage.

@mgrojo mgrojo closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants