NAS/RRC memory leak fix

aligungr · Dec 24, 2021 · 132d7a3 · 132d7a3
1 parent 7bc0d09
commit 132d7a3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/src/lib/nas/base.hpp b/src/lib/nas/base.hpp
@@ -16,6 +16,7 @@ namespace nas
 
 struct InformationElement
 {
+    virtual ~InformationElement() = default;
 };
 
 struct InformationElement1 : InformationElement

diff --git a/src/lib/nas/msg.hpp b/src/lib/nas/msg.hpp
@@ -83,6 +83,9 @@ struct NasMessage
 
   protected:
     NasMessage() = default;
+
+  public:
+    virtual ~NasMessage() = default;
 };
 
 struct SmMessage : NasMessage

diff --git a/src/ue/rrc/connection.cpp b/src/ue/rrc/connection.cpp
@@ -126,6 +126,7 @@ void UeRrcTask::receiveRrcSetup(int cellId, const ASN_RRC_RRCSetup &msg)
 
     m_initialNasPdu = {};
     sendRrcMessage(pdu);
+    asn::Free(asn_DEF_ASN_RRC_UL_DCCH_Message, pdu);
 
     m_logger->info("RRC connection established");
     switchState(ERrcState::RRC_CONNECTED);

diff --git a/src/ue/rrc/nas.cpp b/src/ue/rrc/nas.cpp
@@ -57,6 +57,7 @@ void UeRrcTask::deliverUplinkNas(uint32_t pduId, OctetString &&nasPdu)
     asn::SetOctetString(*c1.choice.ulInformationTransfer->dedicatedNAS_Message, nasPdu);
 
     sendRrcMessage(pdu);
+    asn::Free(asn_DEF_ASN_RRC_UL_DCCH_Message, pdu);
 }
 
 void UeRrcTask::receiveDownlinkInformationTransfer(const ASN_RRC_DLInformationTransfer &msg)
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,7 @@ namespace nas @@
     struct InformationElement
     {
+        virtual ~InformationElement() = default;
     };
     struct InformationElement1 : InformationElement
@@ Expand Down @@