[ui] Python Script Editor Improvements #2587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
reviewed
Nov 15, 2024
| horizontalAlignment: Text.AlignHCenter | ||
| Layout.fillWidth: true | ||
| } | ||
| MSplitView { |
There was a problem hiding this comment.
This needs to be discussed but I wonder if it wouldn't be better to have the split view be horizontal instead of vertical... As such, it's is pretty much unusable unless we expand the Script Editor's tab, which may not be ideal.
There was a problem hiding this comment.
Thanks for your feedback @cbentejac, I do agree with how the widgets are placed in Meshroom at the moment, the best layout is a RowLayout.
Have reverted back in terms of Layout and I guess we can keep it till the time we have a better location/placement of Script Editor.
…xceptions ScriptEditorManager now also allows the code to be saved and retrieved back. Exceptions are now shown with a better output to the user.
ScriptEditor is now part of a ColumnLayout in an MSplitView allowing more control over what is being viewed.
Python syntax within the script editor is now highlighted making it easier to understand and write smaller code in it.
A Row Layout is more practical for using script editor with the current placement of meshroom GUI.
waaake
force-pushed
the
dev/PythonScriptEditor
branch
from
2bd93ff
to
52b52b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ScriptEditor Improvements
Features list