KeyframeSelection: Flag outputExtension attribute when it is set to "none" for video inputs
#2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiceParams can now also have their `validValue` and `errorMessage` parameters. The `validValueChanged` is also emitted whenever a parameter's value changes. This ensures that the `validValue` parameter is always re- evaluated when the attribute is updated, even if `validValue` itself does not change.
If at least one of the inputs is a video, then the `outputExtension` attribute should never be set to "none": if it is, no frame will ever be written on disk, and as a consequence, no SfMData file will be written, meaning that the whole score computation and keyframe selection process will have been done for nothing.
mugulmd
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows #2141 and extends the
validValueanderrorMessageparameters to "Choice" attributes. It additionally ensures that thevalidValueChangedsignal is emitted whenever the attribute's value is updated so it can be re-evaluated, even ifvalidValueitself has not changed.The
outputExtensionattribute from theKeyframeSelectionnode, which determines whether the selected keyframes should be written on disk (and the file extension they should be written on disk with), gets itsvalidValueanderrorMessageparameters to get flagged whenever a video input is part of the list of inputs whileoutputExtensionis set to "none". Indeed, if it is set to "none" for video inputs, no frame will ever be written on disk and, as a consequence, no SfMData file will be written (since it needs a location of the frames on disk), meaning that whole score computation and keyframe selection process will have been done for nothing.