Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage LCP in imageProcessing #2042

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Manage LCP in imageProcessing #2042

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b9a254
[Nodes] imageProcessing: Add LCP related parameters
demoulinv Jun 6, 2023
1c35a28
[Node] imageProcessing: Add chromatic aberration correction option.
demoulinv Aug 14, 2023
1341ad3
[nodes] ImageProcessing: Update node's version
cbentejac Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions meshroom/nodes/aliceVision/ImageProcessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ class ImageProcessing(desc.AVCommandLineNode):
description="Chromatic aberration (fringing) correction if the model parameters are available in the metadata.",
value=False,
uid=[0],
enabled=False # To replace with the line below when the correction of chromatic aberration will be available
# enabled=lambda node: node.lensCorrection.lensCorrectionEnabled.value
enabled=lambda node: node.lensCorrection.lensCorrectionEnabled.value
)
]
),
Expand Down Expand Up @@ -571,6 +570,23 @@ class ImageProcessing(desc.AVCommandLineNode):
uid=[0],
),

desc.File(
name='lensCorrectionProfileInfo',
label='Lens Correction Profile Info',
description='''Lens Correction Profile filepath or database directory.''',
value='${ALICEVISION_LENS_PROFILE_INFO}',
uid=[],
),

desc.BoolParam(
name='lensCorrectionProfileSearchIgnoreCameraModel',
label='LCP Generic Search',
description='The lens name and camera maker are used to match the LCP database, but the camera model is ignored.',
value=True,
uid=[0],
advanced=True,
),

desc.ChoiceParam(
name="storageDataType",
label="Storage Data Type For EXR Output",
Expand Down