Fix bitfield width in ngx_http_conf_addr_t, keep CAP_NET_BIND_SERVICE #1905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
src/http/ngx_http.c
functionngx_http_add_addresses
, the following code is present:This assumes the
protocols
field has width 5 but it is only width 3. This corrupts the next field and causes strange errors. This is fixed by increasing the width to 5 bits.