Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add request_start_time variable #1867

Merged
merged 4 commits into from
Nov 9, 2023
Merged

add request_start_time variable #1867

merged 4 commits into from
Nov 9, 2023

Conversation

drawing
Copy link
Collaborator

@drawing drawing commented Sep 21, 2023

add request_start_time variable

@chobits
Copy link
Member

chobits commented Oct 24, 2023

ACK and we need to introduce one test case for your new variables

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@drawing drawing changed the base branch from tengine-3.1.0 to master November 8, 2023 12:51
@drawing
Copy link
Collaborator Author

drawing commented Nov 9, 2023

ACK and we need to introduce one test case for your new variables

Test case have been added. And the official website documentation has been updated: alibaba/tengine-website-generator#42

@lhanjian
Copy link
Collaborator

lhanjian commented Nov 9, 2023

LGTM

@lhanjian lhanjian merged commit cd2b982 into alibaba:master Nov 9, 2023
9 checks passed
@lhanjian
Copy link
Collaborator

lhanjian commented Nov 9, 2023

An additional question (just curious): under what observability requirements would you use this timing variable?

@drawing

@drawing
Copy link
Collaborator Author

drawing commented Nov 10, 2023 •
edited
Loading

An additional question (just curious): under what observability requirements would you use this timing variable?

@drawing

@lhanjian For example, we want to count the QPS of Taobao's Double 11 promotion. Since the backend business processing time is different, many businesses even timeout and return after several seconds. $time_local is the time when the log is printed, the printing time will behind the request arrival time. The peak value The requests will be scattered and printed in the next few seconds. It is impossible to accurately count the number of peak requests per second. Using $request_start_time to count the peak values can solve this problem.

lhanjian pushed a commit to lhanjian/tengine that referenced this pull request Aug 27, 2024
@drawing @lhanjian
add request_start_time variable (alibaba#1867)
8cb7ceb 
* add request_start_time variable

* request_start_time: format alignment

* request_start_time: add testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhanjian lhanjian lhanjian approved these changes

@chobits chobits chobits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drawing @chobits @CLAassistant @lhanjian