Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: filename wrong in error log when get cpuinfo #1858

Merged
merged 1 commit into from
Sep 7, 2023
Merged

bugfix: filename wrong in error log when get cpuinfo #1858

merged 1 commit into from
Sep 7, 2023

Conversation

fuchencong
Copy link
Contributor

@fuchencong fuchencong commented Sep 7, 2023 •
edited
Loading

Filename wrong in error.log in function ngx_getcpuinfo, it should be NGX_CPUINFO_FILE, not NGX_MEMINFO_FILE.

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@drawing
Copy link
Collaborator

drawing commented Sep 7, 2023

Due to copying the code, the log print uses the wrong file name, thanks for contributing the code.

lianglli
lianglli reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@lianglli lianglli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@lianglli lianglli merged commit 0cbe1a0 into alibaba:master Sep 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lianglli lianglli lianglli left review comments

@drawing drawing drawing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuchencong @CLAassistant @drawing @lianglli