Fix type mismatches in PersonalVault smart contract for Python Challenge 1 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `ptxn.receiver` comparison to use `Global.current_application_address` instead of `Global.current_application_id` to fix type mismatch. - Corrected `op.app_opted_in` function call to pass `Global.current_application_id` instead of `Global.current_application_address`.
|
🎉 Congrats on solving the 1st Algorand Python Coding Challenge! I have labeled your PR approved, so you can now claim your certificate. You can claim your certificate of completion NFT here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algorand Coding Challenge Submission
What was the bug?
The bug occurred in the
PersonalVaultsmart contract'sdepositmethod:ptxn.receiverwas incorrectly compared toGlobal.current_application_idinstead ofGlobal.current_application_address, leading to a type mismatch.op.app_opted_infunction was called with an incorrect type for the second argument, resulting in an error due to an incompatible type comparison.How did you fix the bug?
depositmethod to useGlobal.current_application_addressinstead ofGlobal.current_application_id, ensuring that deposits are correctly sent to the smart contract's account.op.app_opted_inby usingGlobal.current_application_id, aligning it with the expected types.Console Screenshot: