fix(javascript): import type for bundler #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
|
seems like |
shortcuts
commented
Oct 22, 2024
| @@ -6,8 +6,7 @@ | |||
| "packages/*" | |||
| ], | |||
| "scripts": { | |||
| "build:all": "lerna run build --include-dependencies", | |||
| "build:many": "lerna run build --scope 'algoliasearch' --scope '@algolia/requester-testing' --scope '@algolia/logger-console' --scope ${0:-'{@algolia/*,algoliasearch}'} --include-dependencies", | |||
| "build": "lerna run build --scope '@algolia/requester-testing' --scope '@algolia/logger-console' --scope 'algoliasearch' --include-dependencies", | |||
There was a problem hiding this comment.
now that algoliasearch has everything as a deps, we don't need to select what to run, just ask for algoliasearch
algolia-bot
added a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Clément Vannicatte <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Oct 23, 2024
algolia/api-clients-automation#4020 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Clément Vannicatte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3102
Changes included:
close algolia/algoliasearch-client-javascript#1565
close algolia/algoliasearch-client-javascript#1562
seems like tsup doesn't remove type imports if the statement doesn't include
typein it, leading to javascript files with type imports... see https://www.npmjs.com/package/algoliasearch?activeTab=code in/algoliasearch/dist/node.jsL53-L54 for examplealso add https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax to enforce import types consistency