Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-search): removed node apis from worker build #1573

Closed
wants to merge 8 commits into from

Conversation

TorbjornHoltmon
Copy link
Contributor

@TorbjornHoltmon TorbjornHoltmon commented Dec 14, 2024

  • Removed node specific imports from the worker build of client search, replaced them with the web crypto API
  • Added test to verify that the result is the same between node crypto and web crypto

This pull request makes generateSecuredApiKey async, this can cause breaking behavior.
Closes #1567

@TorbjornHoltmon TorbjornHoltmon marked this pull request as ready for review December 14, 2024 18:21
@shortcuts shortcuts self-assigned this Dec 16, 2024
@shortcuts
Copy link
Member

Hey, thanks a lot for your PR! The changes looks really nice, this needs to however be ported to https://github.com/algolia/api-clients-automation as this repository content is fully generated.

I'll move some of your commits there and let you know once it's good :)

@shortcuts
Copy link
Member

Hey again, i've ported changes to algolia/api-clients-automation#4249, also made it to kind of avoid breaking changes so it's a worker specific fix instead

@shortcuts
Copy link
Member

thanks again for the pr!! it has been approve on the automation side, which will land in the next release (5.18.0)

@shortcuts shortcuts closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Unable to use search client in cloudflare workers: Cannot bundle Node.js built-in "crypto"
2 participants