Add header protection and custom header transitions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow mutable access to header values except for when the Unsigned state is active. Altering header values on a signed token of any sort would invalidate the signature associated with that token.
Some token states should allow the alteration or replacement of custom header values, and the added methods here allow that to happen in a type-safe way. As well, they allow for the registered header fields to be reset.
Mutable access to signed or verified headers is not allowed, because that would invalidate the signed or verified signature, so remove the impls for HeaderAccessMut which apply to those states.
alexrudy
force-pushed
the
feature/token-blank-method
branch
from
5fedd3d to
5a0d307
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to protect header modification for signed headers and adds improved constructors and custom header transitions for Token. It also sets the source for TokenVerifyingError signature::Error and removes some header access patterns.