types: move exported objects from index.d.ts to overrides.d.ts (micro…

…soft#7152) This way we generate these types right away, without duplicating them everywhere.
alexplischke · Jun 15, 2021 · b625a04 · b625a04
1 parent b74ca36
commit b625a04
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 21 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -14,11 +14,4 @@
  * limitations under the License.
  */
 
-import * as types from './types/types';
-
 export * from './types/types';
-export const webkit: types.BrowserType;
-export const chromium: types.BrowserType;
-export const firefox: types.BrowserType;
-export const _electron: types.Electron;
-export const _android: types.Android;
diff --git a/packages/common/index.d.ts b/packages/common/index.d.ts
@@ -14,11 +14,4 @@
  * limitations under the License.
  */
 
-import * as types from './types/types';
-
 export * from './types/types';
-export const chromium: types.BrowserType;
-export const firefox: types.BrowserType;
-export const webkit: types.BrowserType;
-export const _electron: types.Electron;
-export const _android: types.Android;
diff --git a/packages/playwright-test/index.d.ts b/packages/playwright-test/index.d.ts
@@ -14,12 +14,5 @@
  * limitations under the License.
  */
 
-import * as types from './types/types';
-
 export * from './types/types';
-export const chromium: types.BrowserType;
-export const firefox: types.BrowserType;
-export const webkit: types.BrowserType;
-export const _electron: types.Electron;
-export const _android: types.Android;
 export * from './types/test';
diff --git a/types/types.d.ts b/types/types.d.ts
@@ -7846,6 +7846,12 @@ export type AndroidKey =
   'Copy' |
   'Paste';
 
+export const chromium: BrowserType;
+export const firefox: BrowserType;
+export const webkit: BrowserType;
+export const _electron: Electron;
+export const _android: Android;
+
 // This is required to not export everything by default. See https://github.com/Microsoft/TypeScript/issues/19545#issuecomment-340490459
 export {};
 

diff --git a/utils/generate_types/overrides.d.ts b/utils/generate_types/overrides.d.ts
@@ -321,5 +321,11 @@ export type AndroidKey =
   'Copy' |
   'Paste';
 
+export const chromium: BrowserType;
+export const firefox: BrowserType;
+export const webkit: BrowserType;
+export const _electron: Electron;
+export const _android: Android;
+
 // This is required to not export everything by default. See https://github.com/Microsoft/TypeScript/issues/19545#issuecomment-340490459
 export {};