Skip to content

Commit

Permalink
Make kerberos an optional and devel dependency for impala and fab (ap…
Browse files Browse the repository at this point in the history
…ache#41616)

The improved compatibility tests detected that FAB provider tests
have implicit dependency on kerberos - similar as impala. This change
make kerberos an optional dependency of FAB as well as it as
development dependency for both impala and FAB.
  • Loading branch information
potiuk authored Aug 20, 2024
1 parent c879501 commit d6df078
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/basic-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ jobs:
env:
HATCH_ENV: "test"
working-directory: ./clients/python
- name: "Install Airflow in editable mode with fab for webserver tests"
run: pip install -e ".[fab]"
- name: "Install Airflow with fab for webserver tests"
run: pip install ".[fab]"
- name: "Install Python client"
run: pip install ./dist/apache_airflow_client-*.whl
- name: "Initialize Airflow DB and start webserver"
Expand Down
2 changes: 2 additions & 0 deletions airflow/providers/apache/impala/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ additional-extras:
dependencies:
- kerberos>=1.3.0

devel-dependencies:
- kerberos>=1.3.0

integrations:
- integration-name: Apache Impala
Expand Down
8 changes: 8 additions & 0 deletions airflow/providers/fab/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ dependencies:
- google-re2>=1.0
- jmespath>=0.7.0

additional-extras:
- name: kerberos
dependencies:
- kerberos>=1.3.0

devel-dependencies:
- kerberos>=1.3.0

config:
fab:
description: This section contains configs specific to FAB provider.
Expand Down
8 changes: 6 additions & 2 deletions generated/provider_dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@
"apache-airflow>=2.8.0",
"impyla>=0.18.0,<1.0"
],
"devel-deps": [],
"devel-deps": [
"kerberos>=1.3.0"
],
"plugins": [],
"cross-providers-deps": [
"common.sql"
Expand Down Expand Up @@ -556,7 +558,9 @@
"google-re2>=1.0",
"jmespath>=0.7.0"
],
"devel-deps": [],
"devel-deps": [
"kerberos>=1.3.0"
],
"plugins": [],
"cross-providers-deps": [],
"excluded-python-versions": [],
Expand Down

0 comments on commit d6df078

Please sign in to comment.